Tools/git-repo
1
0
Fork 0
Code Activity

Update patch set 20

Browse source 
Patch Set 20: Verified+1

(3 comments)

Patch-set: 20
Label: Verified=+1, fd289b2ed572615de3f82b225de60397720f2f88
Attention: {"person_ident":"Gerrit User 4127492 \u003c4127492@173816e5-2b9a-37c3-8a2e-48639d4f1153\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_4127492\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 1142791 \u003c1142791@173816e5-2b9a-37c3-8a2e-48639d4f1153\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_4127492\u003e replied on the change"}
This commit is contained in:
Gerrit User 4127492 2025-06-27 17:57:46 -07:00 • committed by Gerrit Code Review
parent 66d23b5d12
commit c7f96eabe2
2 changed files with 69 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

21
795e9803efbf5d38ee20276c35f2e2671dabfb08 Normal file
View file

@ -0,0 +1,21 @@
{
"comments": [
{
"unresolved": false,
"key": {
"uuid": "15044263_846e2ad0",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 20
},
"lineNbr": 0,
"author": {
"id": 4127492
},
"writtenOn": "2025-06-28T00:57:46Z",
"side": 1,
"message": "I reworded the sentence to clarify that the hook still runs even if no checkout happens (e.g. `-n`, partial sync).",
"revId": "795e9803efbf5d38ee20276c35f2e2671dabfb08",
"serverId": "173816e5-2b9a-37c3-8a2e-48639d4f1153"
}
]
}

48
9fdf1e71c377c3671ea93ad2cc4e07d72edbe31f
View file

@ -74,6 +74,30 @@
"revId": "9fdf1e71c377c3671ea93ad2cc4e07d72edbe31f", "revId": "9fdf1e71c377c3671ea93ad2cc4e07d72edbe31f",
"serverId": "173816e5-2b9a-37c3-8a2e-48639d4f1153" "serverId": "173816e5-2b9a-37c3-8a2e-48639d4f1153"
}, },
{
"unresolved": false,
"key": {
"uuid": "1a0f1538_288c82a2",
"filename": "docs/repo-hooks.md",
"patchSetId": 19
},
"lineNbr": 139,
"author": {
"id": 4127492
},
"writtenOn": "2025-06-28T00:57:46Z",
"side": 1,
"message": "Actually, L143 and L144 were added based on feedback from an earlier reviewer to clarify that `repo sync` may succeed without actually checking out any projects (e.g. via `-n` or partial syncs).\n\nThe intent is to make it clear that the hook may still run in those cases, even though no files were touched.",
"parentUuid": "6ae303f9_7d0bf858",
"range": {
"startLine": 139,
"startChar": 20,
"endLine": 139,
"endChar": 57
},
"revId": "9fdf1e71c377c3671ea93ad2cc4e07d72edbe31f",
"serverId": "173816e5-2b9a-37c3-8a2e-48639d4f1153"
},
{ {
"unresolved": true, "unresolved": true,
"key": { "key": {
@ -96,6 +120,30 @@
}, },
"revId": "9fdf1e71c377c3671ea93ad2cc4e07d72edbe31f", "revId": "9fdf1e71c377c3671ea93ad2cc4e07d72edbe31f",
"serverId": "173816e5-2b9a-37c3-8a2e-48639d4f1153" "serverId": "173816e5-2b9a-37c3-8a2e-48639d4f1153"
},
{
"unresolved": false,
"key": {
"uuid": "8dd8fda0_be6507eb",
"filename": "docs/repo-hooks.md",
"patchSetId": 19
},
"lineNbr": 153,
"author": {
"id": 4127492
},
"writtenOn": "2025-06-28T00:57:46Z",
"side": 1,
"message": "the `post-sync` hook is triggered after any successful `repo sync`, regardless of whether it performed a full checkout, partial sync, or network-only fetch (`-n`).\n\nWhile it\u0027s most useful after a full sync, the current behavior intentionally allows it to run in all successful sync scenarios, to avoid requiring custom wrappers around `repo sync`.",
"parentUuid": "47506231_09e74daf",
"range": {
"startLine": 139,
"startChar": 1,
"endLine": 153,
"endChar": 0
},
"revId": "9fdf1e71c377c3671ea93ad2cc4e07d72edbe31f",
"serverId": "173816e5-2b9a-37c3-8a2e-48639d4f1153"
} }
] ]
} }