From c7f96eabe24e8f502b84ad79009b93932969aa89 Mon Sep 17 00:00:00 2001 From: Gerrit User 4127492 <4127492@173816e5-2b9a-37c3-8a2e-48639d4f1153> Date: Fri, 27 Jun 2025 17:57:46 -0700 Subject: [PATCH] Update patch set 20 Patch Set 20: Verified+1 (3 comments) Patch-set: 20 Label: Verified=+1, fd289b2ed572615de3f82b225de60397720f2f88 Attention: {"person_ident":"Gerrit User 4127492 \u003c4127492@173816e5-2b9a-37c3-8a2e-48639d4f1153\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_4127492\u003e replied on the change"} Attention: {"person_ident":"Gerrit User 1142791 \u003c1142791@173816e5-2b9a-37c3-8a2e-48639d4f1153\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_4127492\u003e replied on the change"} --- 795e9803efbf5d38ee20276c35f2e2671dabfb08 | 21 +++++++++++ 9fdf1e71c377c3671ea93ad2cc4e07d72edbe31f | 48 ++++++++++++++++++++++++ 2 files changed, 69 insertions(+) create mode 100644 795e9803efbf5d38ee20276c35f2e2671dabfb08 diff --git a/795e9803efbf5d38ee20276c35f2e2671dabfb08 b/795e9803efbf5d38ee20276c35f2e2671dabfb08 new file mode 100644 index 000000000..4f64fc6df --- /dev/null +++ b/795e9803efbf5d38ee20276c35f2e2671dabfb08 @@ -0,0 +1,21 @@ +{ + "comments": [ + { + "unresolved": false, + "key": { + "uuid": "15044263_846e2ad0", + "filename": "/PATCHSET_LEVEL", + "patchSetId": 20 + }, + "lineNbr": 0, + "author": { + "id": 4127492 + }, + "writtenOn": "2025-06-28T00:57:46Z", + "side": 1, + "message": "I reworded the sentence to clarify that the hook still runs even if no checkout happens (e.g. `-n`, partial sync).", + "revId": "795e9803efbf5d38ee20276c35f2e2671dabfb08", + "serverId": "173816e5-2b9a-37c3-8a2e-48639d4f1153" + } + ] +} \ No newline at end of file diff --git a/9fdf1e71c377c3671ea93ad2cc4e07d72edbe31f b/9fdf1e71c377c3671ea93ad2cc4e07d72edbe31f index a13661c89..0538527ce 100644 --- a/9fdf1e71c377c3671ea93ad2cc4e07d72edbe31f +++ b/9fdf1e71c377c3671ea93ad2cc4e07d72edbe31f @@ -74,6 +74,30 @@ "revId": "9fdf1e71c377c3671ea93ad2cc4e07d72edbe31f", "serverId": "173816e5-2b9a-37c3-8a2e-48639d4f1153" }, + { + "unresolved": false, + "key": { + "uuid": "1a0f1538_288c82a2", + "filename": "docs/repo-hooks.md", + "patchSetId": 19 + }, + "lineNbr": 139, + "author": { + "id": 4127492 + }, + "writtenOn": "2025-06-28T00:57:46Z", + "side": 1, + "message": "Actually, L143 and L144 were added based on feedback from an earlier reviewer to clarify that `repo sync` may succeed without actually checking out any projects (e.g. via `-n` or partial syncs).\n\nThe intent is to make it clear that the hook may still run in those cases, even though no files were touched.", + "parentUuid": "6ae303f9_7d0bf858", + "range": { + "startLine": 139, + "startChar": 20, + "endLine": 139, + "endChar": 57 + }, + "revId": "9fdf1e71c377c3671ea93ad2cc4e07d72edbe31f", + "serverId": "173816e5-2b9a-37c3-8a2e-48639d4f1153" + }, { "unresolved": true, "key": { @@ -96,6 +120,30 @@ }, "revId": "9fdf1e71c377c3671ea93ad2cc4e07d72edbe31f", "serverId": "173816e5-2b9a-37c3-8a2e-48639d4f1153" + }, + { + "unresolved": false, + "key": { + "uuid": "8dd8fda0_be6507eb", + "filename": "docs/repo-hooks.md", + "patchSetId": 19 + }, + "lineNbr": 153, + "author": { + "id": 4127492 + }, + "writtenOn": "2025-06-28T00:57:46Z", + "side": 1, + "message": "the `post-sync` hook is triggered after any successful `repo sync`, regardless of whether it performed a full checkout, partial sync, or network-only fetch (`-n`).\n\nWhile it\u0027s most useful after a full sync, the current behavior intentionally allows it to run in all successful sync scenarios, to avoid requiring custom wrappers around `repo sync`.", + "parentUuid": "47506231_09e74daf", + "range": { + "startLine": 139, + "startChar": 1, + "endLine": 153, + "endChar": 0 + }, + "revId": "9fdf1e71c377c3671ea93ad2cc4e07d72edbe31f", + "serverId": "173816e5-2b9a-37c3-8a2e-48639d4f1153" } ] } \ No newline at end of file