d04b41cc6d
Patch Set 1: Commit-Queue+2 Verified+1
(1 comment)
Patch-set: 1
Reviewer: Gerrit User 1096638 <1096638@173816e5-2b9a-37c3-8a2e-48639d4f1153>
Label: Verified=+1, f1b395aa18880b2ddecce361b365188455bf4ce8
Label: Commit-Queue=+2, 24b963579fca6485a887c057dac9b42985e95525
Attention: {"person_ident":"Gerrit User 1096638 \u003c1096638@173816e5-2b9a-37c3-8a2e-48639d4f1153\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_1096638\u003e replied on the change"}
39 lines
No EOL
1.2 KiB
Text
39 lines
No EOL
1.2 KiB
Text
{
|
|
"comments": [
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "27813399_87960ea1",
|
|
"filename": "project.py",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 2715,
|
|
"author": {
|
|
"id": 1088583
|
|
},
|
|
"writtenOn": "2024-10-03T20:37:43Z",
|
|
"side": 1,
|
|
"message": "do we also want to `raise GitAuthError` here too?",
|
|
"revId": "82fe40f273b511b79e13fe5129ac079a6548e600",
|
|
"serverId": "173816e5-2b9a-37c3-8a2e-48639d4f1153"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "d02070e3_1854c168",
|
|
"filename": "project.py",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 2715,
|
|
"author": {
|
|
"id": 1096638
|
|
},
|
|
"writtenOn": "2024-10-03T20:47:43Z",
|
|
"side": 1,
|
|
"message": "That one is a bit trickier since there could be multiple remotes in manifest, and user may have access only to some. git sso is more straightforward.\n\nWe can revisit once we get better understanding how it affects sso users.",
|
|
"parentUuid": "27813399_87960ea1",
|
|
"revId": "82fe40f273b511b79e13fe5129ac079a6548e600",
|
|
"serverId": "173816e5-2b9a-37c3-8a2e-48639d4f1153"
|
|
}
|
|
]
|
|
} |