Change has been successfully rebased and submitted asf7f9dd4deb
Patch-set: 2 Patch-set-description: Rebase Subject: project: Handle git sso auth failures as repo exit Status: merged Commit:f7f9dd4deb
Tag: autogenerated:gerrit:merged Groups:82fe40f273
Label: Verified=+1, 38b886fc71faf246f5cf935d5bf9ef743d0b2b8c Gerrit User 1096638 <1096638@173816e5-2b9a-37c3-8a2e-48639d4f1153> Label: Code-Review=+2, a74f14fe52d645b2fd23114d3052a6f1fb682b12 Gerrit User 1088583 <1088583@173816e5-2b9a-37c3-8a2e-48639d4f1153> Label: Commit-Queue=+2, 095ae1fd3a54d632ecaf3726f1952338d9b6beb1 Gerrit User 1096638 <1096638@173816e5-2b9a-37c3-8a2e-48639d4f1153> Label: SUBM=+1, fe585b0b99e964afe865c43eeac7a9275d4b17dd Submission-id: 438522 Submitted-with: OK Submitted-with: Rule-Name: gerrit~DefaultSubmitRule Submitted-with: MAY: Verified: Gerrit User 1096638 <1096638@173816e5-2b9a-37c3-8a2e-48639d4f1153> Submitted-with: MAY: Code-Review: Gerrit User 1088583 <1088583@173816e5-2b9a-37c3-8a2e-48639d4f1153> Submitted-with: MAY: Commit-Queue: Gerrit User 1096638 <1096638@173816e5-2b9a-37c3-8a2e-48639d4f1153> Submitted-with: MAY: Bot-Commit Submitted-with: MAY: Auto-Submit Submitted-with: MAY: Lint
190 lines
No EOL
7.2 KiB
Text
190 lines
No EOL
7.2 KiB
Text
{
|
|
"comments": [
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "27813399_87960ea1",
|
|
"filename": "project.py",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 2715,
|
|
"author": {
|
|
"id": 1088583
|
|
},
|
|
"writtenOn": "2024-10-03T20:37:43Z",
|
|
"side": 1,
|
|
"message": "do we also want to `raise GitAuthError` here too?",
|
|
"revId": "82fe40f273b511b79e13fe5129ac079a6548e600",
|
|
"serverId": "173816e5-2b9a-37c3-8a2e-48639d4f1153"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "d02070e3_1854c168",
|
|
"filename": "project.py",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 2715,
|
|
"author": {
|
|
"id": 1096638
|
|
},
|
|
"writtenOn": "2024-10-03T20:47:43Z",
|
|
"side": 1,
|
|
"message": "That one is a bit trickier since there could be multiple remotes in manifest, and user may have access only to some. git sso is more straightforward.\n\nWe can revisit once we get better understanding how it affects sso users.",
|
|
"parentUuid": "27813399_87960ea1",
|
|
"revId": "82fe40f273b511b79e13fe5129ac079a6548e600",
|
|
"serverId": "173816e5-2b9a-37c3-8a2e-48639d4f1153"
|
|
}
|
|
],
|
|
"submitRequirementResults": [
|
|
{
|
|
"submitRequirement": {
|
|
"name": "Code-Review",
|
|
"description": {
|
|
"value": "Submit requirement for the \u0027Code-Review\u0027 label"
|
|
},
|
|
"applicabilityExpression": {},
|
|
"submittabilityExpression": {
|
|
"expressionString": "label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN"
|
|
},
|
|
"overrideExpression": {},
|
|
"allowOverrideInChildProjects": true
|
|
},
|
|
"applicabilityExpressionResult": {},
|
|
"submittabilityExpressionResult": {
|
|
"value": {"expression":{"expressionString":"label:Code-Review=MAX AND -label:Code-Review=MIN"},"status":"PASS","errorMessage":{"value":null},"passingAtoms":["label:Code-Review=MAX"],"failingAtoms":["label:Code-Review=MIN"]}
|
|
},
|
|
"overrideExpressionResult": {},
|
|
"patchSetCommitId": "82fe40f273b511b79e13fe5129ac079a6548e600",
|
|
"legacy": {
|
|
"value": false
|
|
},
|
|
"forced": {},
|
|
"hidden": {}
|
|
},
|
|
{
|
|
"submitRequirement": {
|
|
"name": "Do-Not-Submit",
|
|
"description": {
|
|
"value": "Changes that have DO NOT SUBMIT in their commit message are not submittable."
|
|
},
|
|
"applicabilityExpression": {
|
|
"value": {
|
|
"expressionString": "message:\"^.*(D|d)(O|o) (N|n)(O|o)(T|t) (S|s)(U|u)(B|b)(M|m)(I|i)(T|t).*\""
|
|
}
|
|
},
|
|
"submittabilityExpression": {
|
|
"expressionString": "is:false"
|
|
},
|
|
"overrideExpression": {},
|
|
"allowOverrideInChildProjects": false
|
|
},
|
|
"applicabilityExpressionResult": {
|
|
"value": {"expression":{"expressionString":"message:\"^.*(D|d)(O|o) (N|n)(O|o)(T|t) (S|s)(U|u)(B|b)(M|m)(I|i)(T|t).*\""},"status":"FAIL","errorMessage":{"value":null},"passingAtoms":[],"failingAtoms":["message:\"^.*(D|d)(O|o) (N|n)(O|o)(T|t) (S|s)(U|u)(B|b)(M|m)(I|i)(T|t).*\""]}
|
|
},
|
|
"submittabilityExpressionResult": {
|
|
"value": {"expression":{"expressionString":"is:false"},"status":"NOT_EVALUATED","errorMessage":{"value":null},"passingAtoms":[],"failingAtoms":[]}
|
|
},
|
|
"overrideExpressionResult": {},
|
|
"patchSetCommitId": "82fe40f273b511b79e13fe5129ac079a6548e600",
|
|
"legacy": {
|
|
"value": false
|
|
},
|
|
"forced": {},
|
|
"hidden": {}
|
|
},
|
|
{
|
|
"submitRequirement": {
|
|
"name": "No-Unresolved-Comments",
|
|
"description": {
|
|
"value": "Changes that have unresolved comments are not submittable. Unless overriden by adding the hashtag allow-unresolved-comments."
|
|
},
|
|
"applicabilityExpression": {
|
|
"value": {
|
|
"expressionString": "has:unresolved"
|
|
}
|
|
},
|
|
"submittabilityExpression": {
|
|
"expressionString": "-has:unresolved"
|
|
},
|
|
"overrideExpression": {
|
|
"value": {
|
|
"expressionString": "hashtag:allow-unresolved-comments"
|
|
}
|
|
},
|
|
"allowOverrideInChildProjects": false
|
|
},
|
|
"applicabilityExpressionResult": {
|
|
"value": {"expression":{"expressionString":"has:unresolved"},"status":"FAIL","errorMessage":{"value":null},"passingAtoms":[],"failingAtoms":["has:unresolved"]}
|
|
},
|
|
"submittabilityExpressionResult": {
|
|
"value": {"expression":{"expressionString":"-has:unresolved"},"status":"NOT_EVALUATED","errorMessage":{"value":null},"passingAtoms":[],"failingAtoms":[]}
|
|
},
|
|
"overrideExpressionResult": {
|
|
"value": {"expression":{"expressionString":"hashtag:allow-unresolved-comments"},"status":"NOT_EVALUATED","errorMessage":{"value":null},"passingAtoms":[],"failingAtoms":[]}
|
|
},
|
|
"patchSetCommitId": "82fe40f273b511b79e13fe5129ac079a6548e600",
|
|
"legacy": {
|
|
"value": false
|
|
},
|
|
"forced": {},
|
|
"hidden": {}
|
|
},
|
|
{
|
|
"submitRequirement": {
|
|
"name": "Review-Enforcement",
|
|
"description": {
|
|
"value": "Two Google employees must approve the change. Uploading the change or voting positively on Code-Review count as approval. Using a trusted device is required, see go/gerrit-onboarding#review-enforcement."
|
|
},
|
|
"applicabilityExpression": {
|
|
"value": {
|
|
"expressionString": "is:review-enforced_gerrit"
|
|
}
|
|
},
|
|
"submittabilityExpression": {
|
|
"expressionString": "is:review-enforcement-satisfied_gerrit"
|
|
},
|
|
"overrideExpression": {},
|
|
"allowOverrideInChildProjects": false
|
|
},
|
|
"applicabilityExpressionResult": {
|
|
"value": {"expression":{"expressionString":"is:review-enforced_gerrit"},"status":"FAIL","errorMessage":{"value":null},"passingAtoms":[],"failingAtoms":["is:review-enforced_gerrit"]}
|
|
},
|
|
"submittabilityExpressionResult": {
|
|
"value": {"expression":{"expressionString":"is:review-enforcement-satisfied_gerrit"},"status":"NOT_EVALUATED","errorMessage":{"value":null},"passingAtoms":[],"failingAtoms":[]}
|
|
},
|
|
"overrideExpressionResult": {},
|
|
"patchSetCommitId": "82fe40f273b511b79e13fe5129ac079a6548e600",
|
|
"legacy": {
|
|
"value": false
|
|
},
|
|
"forced": {},
|
|
"hidden": {}
|
|
},
|
|
{
|
|
"submitRequirement": {
|
|
"name": "Verified",
|
|
"description": {
|
|
"value": "Submit requirement for the \u0027Verified\u0027 label"
|
|
},
|
|
"applicabilityExpression": {},
|
|
"submittabilityExpression": {
|
|
"expressionString": "label:Verified\u003dMAX AND -label:Verified\u003dMIN"
|
|
},
|
|
"overrideExpression": {},
|
|
"allowOverrideInChildProjects": true
|
|
},
|
|
"applicabilityExpressionResult": {},
|
|
"submittabilityExpressionResult": {
|
|
"value": {"expression":{"expressionString":"label:Verified=MAX AND -label:Verified=MIN"},"status":"PASS","errorMessage":{"value":null},"passingAtoms":["label:Verified=MAX"],"failingAtoms":["label:Verified=MIN"]}
|
|
},
|
|
"overrideExpressionResult": {},
|
|
"patchSetCommitId": "82fe40f273b511b79e13fe5129ac079a6548e600",
|
|
"legacy": {
|
|
"value": false
|
|
},
|
|
"forced": {},
|
|
"hidden": {}
|
|
}
|
|
]
|
|
} |