From ed267e83e336adc4ab799210c1250bc4cb79bedf Mon Sep 17 00:00:00 2001 From: Gerrit User 1007145 <1007145@173816e5-2b9a-37c3-8a2e-48639d4f1153> Date: Mon, 16 Jun 2025 20:48:57 -0700 Subject: [PATCH] Update patch set 1 Patch Set 1: (2 comments) Patch-set: 1 Attention: {"person_ident":"Gerrit User 1007145 \u003c1007145@173816e5-2b9a-37c3-8a2e-48639d4f1153\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_1007145\u003e replied on the change"} Attention: {"person_ident":"Gerrit User 1167047 \u003c1167047@173816e5-2b9a-37c3-8a2e-48639d4f1153\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_1007145\u003e replied on the change"} --- d3d775fb64dd53be421a007088f8494163bb52e4 | 66 ++++++++++++++++++++++++ 1 file changed, 66 insertions(+) create mode 100644 d3d775fb64dd53be421a007088f8494163bb52e4 diff --git a/d3d775fb64dd53be421a007088f8494163bb52e4 b/d3d775fb64dd53be421a007088f8494163bb52e4 new file mode 100644 index 000000000..5c0719b8c --- /dev/null +++ b/d3d775fb64dd53be421a007088f8494163bb52e4 @@ -0,0 +1,66 @@ +{ + "comments": [ + { + "unresolved": true, + "key": { + "uuid": "2bf969f0_1b80284d", + "filename": "/COMMIT_MSG", + "patchSetId": 1 + }, + "lineNbr": 7, + "author": { + "id": 1007145 + }, + "writtenOn": "2025-06-17T03:48:57Z", + "side": 1, + "message": "when changing a specific command, better to prefix the commit like `info:`", + "revId": "d3d775fb64dd53be421a007088f8494163bb52e4", + "serverId": "173816e5-2b9a-37c3-8a2e-48639d4f1153" + }, + { + "unresolved": true, + "key": { + "uuid": "95f87eb5_6603cbe1", + "filename": "subcmds/info.py", + "patchSetId": 1 + }, + "lineNbr": 106, + "author": { + "id": 1007145 + }, + "writtenOn": "2025-06-17T03:48:57Z", + "side": 1, + "message": "if `commit_id` has a trailing newline, we should fix that in its definition\n\nif we want to add a newline to the output, we should use the helper instead of embedding it in", + "fixSuggestions": [ + { + "fixId": "492cd2a7_3ec7944e", + "description": "prompt_to_edit API", + "replacements": [ + { + "path": "subcmds/info.py", + "range": { + "startLine": 106, + "startChar": 0, + "endLine": 107, + "endChar": 0 + }, + "replacement": " srev \u003d sp.commit_id if sp and sp.commit_id else \"None\"\n" + }, + { + "path": "subcmds/info.py", + "range": { + "startLine": 109, + "startChar": 0, + "endLine": 109, + "endChar": 0 + }, + "replacement": " self.out.nl()\n" + } + ] + } + ], + "revId": "d3d775fb64dd53be421a007088f8494163bb52e4", + "serverId": "173816e5-2b9a-37c3-8a2e-48639d4f1153" + } + ] +} \ No newline at end of file