Tools/git-repo
1
0
Fork 0
Code Activity

Update patch set 13

Browse source 
Patch Set 13:

(6 comments)

Patch-set: 13
Attention: {"person_ident":"Gerrit User 4127492 \u003c4127492@173816e5-2b9a-37c3-8a2e-48639d4f1153\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_4127492\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 1007145 \u003c1007145@173816e5-2b9a-37c3-8a2e-48639d4f1153\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_4127492\u003e replied on the change"}
This commit is contained in:
Gerrit User 4127492 2025-06-05 16:28:47 -07:00 • committed by Gerrit Code Review
parent 0c2e5c381e
commit dbc9a6cb5f
1 changed files with 114 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

114
14bf8434de714f0381eabc93a4d2735d5ff1331b
View file

@ -17,6 +17,24 @@
"revId": "14bf8434de714f0381eabc93a4d2735d5ff1331b",
"serverId": "173816e5-2b9a-37c3-8a2e-48639d4f1153"
},
{
"unresolved": false,
"key": {
"uuid": "d860e6c2_56cd5edf",
"filename": "/COMMIT_MSG",
"patchSetId": 12
},
"lineNbr": 29,
"author": {
"id": 4127492
},
"writtenOn": "2025-06-05T23:28:47Z",
"side": 1,
"message": "Done",
"parentUuid": "59c9c9c4_89d60e08",
"revId": "14bf8434de714f0381eabc93a4d2735d5ff1331b",
"serverId": "173816e5-2b9a-37c3-8a2e-48639d4f1153"
},
{
"unresolved": true,
"key": {
@ -40,6 +58,30 @@
"revId": "14bf8434de714f0381eabc93a4d2735d5ff1331b",
"serverId": "173816e5-2b9a-37c3-8a2e-48639d4f1153"
},
{
"unresolved": false,
"key": {
"uuid": "2125c86f_a658b237",
"filename": "docs/repo-hooks.md",
"patchSetId": 12
},
"lineNbr": 140,
"author": {
"id": 4127492
},
"writtenOn": "2025-06-05T23:28:47Z",
"side": 1,
"message": "Thanks again — I updated the doc to clarify that `post-sync` runs after a successful `repo sync`, but doesn’t imply all projects were synced or checked out.\n\nIncluded examples like `repo sync -n` and single-project sync to make that nuance clear.\n\nLet me know if the new wording looks better!",
"parentUuid": "07cb7682_677369b6",
"range": {
"startLine": 139,
"startChar": 0,
"endLine": 140,
"endChar": 24
},
"revId": "14bf8434de714f0381eabc93a4d2735d5ff1331b",
"serverId": "173816e5-2b9a-37c3-8a2e-48639d4f1153"
},
{
"unresolved": true,
"key": {
@ -75,6 +117,24 @@
"revId": "14bf8434de714f0381eabc93a4d2735d5ff1331b",
"serverId": "173816e5-2b9a-37c3-8a2e-48639d4f1153"
},
{
"unresolved": false,
"key": {
"uuid": "502e4435_bea92ca6",
"filename": "docs/repo-hooks.md",
"patchSetId": 12
},
"lineNbr": 160,
"author": {
"id": 4127492
},
"writtenOn": "2025-06-05T23:28:47Z",
"side": 1,
"message": "Fix applied.",
"parentUuid": "85743790_92615476",
"revId": "14bf8434de714f0381eabc93a4d2735d5ff1331b",
"serverId": "173816e5-2b9a-37c3-8a2e-48639d4f1153"
},
{
"unresolved": true,
"key": {
@ -92,6 +152,24 @@
"revId": "14bf8434de714f0381eabc93a4d2735d5ff1331b",
"serverId": "173816e5-2b9a-37c3-8a2e-48639d4f1153"
},
{
"unresolved": false,
"key": {
"uuid": "78f3ab22_7858f073",
"filename": "subcmds/sync.py",
"patchSetId": 12
},
"lineNbr": 1741,
"author": {
"id": 4127492
},
"writtenOn": "2025-06-05T23:28:47Z",
"side": 1,
"message": "- Removed outer try/except around `_RunPostSyncHook()`\n- Relying on `RepoHook.Run()` return value to detect failure, as suggested\n- Confirmed `post-sync` only runs after successful sync, and doesn\u0027t affect error flow\n\nThanks again for the detailed feedback — let me know if anything else needs tweaking!",
"parentUuid": "be0623aa_860ab365",
"revId": "14bf8434de714f0381eabc93a4d2735d5ff1331b",
"serverId": "173816e5-2b9a-37c3-8a2e-48639d4f1153"
},
{
"unresolved": true,
"key": {
@ -137,6 +215,24 @@
"revId": "14bf8434de714f0381eabc93a4d2735d5ff1331b",
"serverId": "173816e5-2b9a-37c3-8a2e-48639d4f1153"
},
{
"unresolved": false,
"key": {
"uuid": "3e676db7_07d3153b",
"filename": "subcmds/sync.py",
"patchSetId": 12
},
"lineNbr": 1751,
"author": {
"id": 4127492
},
"writtenOn": "2025-06-05T23:28:47Z",
"side": 1,
"message": "Done",
"parentUuid": "e25d6a19_bf3fb817",
"revId": "14bf8434de714f0381eabc93a4d2735d5ff1331b",
"serverId": "173816e5-2b9a-37c3-8a2e-48639d4f1153"
},
{
"unresolved": true,
"key": {
@ -153,6 +249,24 @@
"message": "this try/except block is useless as the Run method already catches everything it should. the only thing the caller should look at is the bool return value.",
"revId": "14bf8434de714f0381eabc93a4d2735d5ff1331b",
"serverId": "173816e5-2b9a-37c3-8a2e-48639d4f1153"
},
{
"unresolved": false,
"key": {
"uuid": "18d49a7b_61fd0b3c",
"filename": "subcmds/sync.py",
"patchSetId": 12
},
"lineNbr": 1759,
"author": {
"id": 4127492
},
"writtenOn": "2025-06-05T23:28:47Z",
"side": 1,
"message": "Thanks — good point.\n\nI removed the outer try/except from `_RunPostSyncHook()`, and now rely on the boolean return value from `Run()` to detect failure, as `RepoHook` already handles exceptions internally.",
"parentUuid": "eecc2f74_eec94755",
"revId": "14bf8434de714f0381eabc93a4d2735d5ff1331b",
"serverId": "173816e5-2b9a-37c3-8a2e-48639d4f1153"
}
]
}