Tools/git-repo
1
0
Fork 0
Code Activity

Update patch set 9

Browse source 
Patch Set 9:

(2 comments)

Patch-set: 9
Attention: {"person_ident":"Gerrit User 4127492 \u003c4127492@173816e5-2b9a-37c3-8a2e-48639d4f1153\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_4127492\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 1002666 \u003c1002666@173816e5-2b9a-37c3-8a2e-48639d4f1153\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_4127492\u003e replied on the change"}
This commit is contained in:
Gerrit User 4127492 2025-06-03 20:15:57 -07:00 • committed by Gerrit Code Review
parent 59901a1092
commit d8c8697b91
2 changed files with 39 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

21
50620d2a2d6324ca0e8e34329d13626f064ceee4 Normal file
View file

@ -0,0 +1,21 @@
{
"comments": [
{
"unresolved": false,
"key": {
"uuid": "aac8f3d7_9fc81e31",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 9
},
"lineNbr": 0,
"author": {
"id": 4127492
},
"writtenOn": "2025-06-04T03:15:57Z",
"side": 1,
"message": "In patchset 9, I updated the code to use the actual `opt` passed to `Execute()` instead of constructing a dummy. I also ensured the required fields (`bypass_hooks`, `allow_all_hooks`, and `ignore_hooks`) are set with safe defaults if not present.\n\nThis keeps the implementation in line with `RepoHook.FromSubcmd()` expectations without changing the CLI interface.\n\nThanks again for the feedback — it\u0027s cleaner now!",
"revId": "50620d2a2d6324ca0e8e34329d13626f064ceee4",
"serverId": "173816e5-2b9a-37c3-8a2e-48639d4f1153"
}
]
}

18
54227f79bcb8a6af52c6075066ac681c7b9e02f4
View file

@ -16,6 +16,24 @@
"message": "I think you should be using the `RepoHook.FromSubcmd()` static method to populate most of the constructor args. Check the usage in `subcmds/upload.py`.",
"revId": "54227f79bcb8a6af52c6075066ac681c7b9e02f4",
"serverId": "173816e5-2b9a-37c3-8a2e-48639d4f1153"
},
{
"unresolved": false,
"key": {
"uuid": "eb8f03d1_0b40ea3c",
"filename": "subcmds/sync.py",
"patchSetId": 4
},
"lineNbr": 1753,
"author": {
"id": 4127492
},
"writtenOn": "2025-06-04T03:15:57Z",
"side": 1,
"message": "Thanks for the suggestion! Addressed in patchset 7.\n\n- Switched to `RepoHook.FromSubcmd()` for hook construction (same pattern as in `upload.py`)\n- Since `sync` doesn\u0027t have a native `opt` object, I introduced a minimal `DummyOpt` with the required attributes:\n - `bypass_hooks`\n - `allow_all_hooks`\n - `ignore_hooks`\n\nThis keeps the change self-contained without modifying `RepoHook` itself. Let me know if you\u0027d prefer an alternative (e.g., fallback handling inside `FromSubcmd()`).",
"parentUuid": "39f7fbc6_e71028de",
"revId": "54227f79bcb8a6af52c6075066ac681c7b9e02f4",
"serverId": "173816e5-2b9a-37c3-8a2e-48639d4f1153"
}
]
}