Tools/git-repo
1
0
Fork 0
Code Activity

Fix error parsing a non-existant configuration file

Browse source 
If a file (e.g. ~/.gitconfig) does not exist, we get None
here rather than a string.  NoneType lacks rstrip() so we
cannot strip it.

Signed-off-by: Shawn O. Pearce <sop@google.com>
This commit is contained in:
Shawn O. Pearce 2009-07-02 16:12:57 -07:00
parent 2d1a396897
commit c24c720b61
2 changed files with 13 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

9
tests/test_git_config.py
View file

@ -39,5 +39,14 @@ class GitConfigUnitTest(unittest.TestCase):
val = self.config.GetString('section.nonempty')
self.assertEqual(val, 'true')
def test_GetString_from_missing_file(self):
"""
Test missing config file
"""
config_fixture = fixture('not.present.gitconfig')
config = git_config.GitConfig(config_fixture)
val = config.GetString('empty')
self.assertEqual(val, None)
if __name__ == '__main__':
unittest.main()