From bc14b58d36a83523791b3e8b7a59bb33fd73d319 Mon Sep 17 00:00:00 2001 From: Gerrit User 1007145 <1007145@173816e5-2b9a-37c3-8a2e-48639d4f1153> Date: Tue, 8 Jul 2025 16:51:27 -0700 Subject: [PATCH] Update patch set 2 Patch Set 2: (2 comments) Patch-set: 2 CC: Gerrit User 1007145 <1007145@173816e5-2b9a-37c3-8a2e-48639d4f1153> Attention: {"person_ident":"Gerrit User 3614203 \u003c3614203@173816e5-2b9a-37c3-8a2e-48639d4f1153\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_1007145\u003e replied on the change"} --- 21269c3eedc428610a5cab1494b2459a7e939fc7 | 35 ++++++++++++++++++++++++ 1 file changed, 35 insertions(+) diff --git a/21269c3eedc428610a5cab1494b2459a7e939fc7 b/21269c3eedc428610a5cab1494b2459a7e939fc7 index 9d4510b54..81af5f25e 100644 --- a/21269c3eedc428610a5cab1494b2459a7e939fc7 +++ b/21269c3eedc428610a5cab1494b2459a7e939fc7 @@ -16,6 +16,41 @@ "message": "@gavinmak@google.com @ddoman@google.com thanks for the reviews. I had almost given up on this patch.\n\nI\u0027m curious what\u0027s the \"right\" way to get reviewers assigned. I was following along with SUBMITTING_PATCHES.md with no issues until this step.", "revId": "21269c3eedc428610a5cab1494b2459a7e939fc7", "serverId": "173816e5-2b9a-37c3-8a2e-48639d4f1153" + }, + { + "unresolved": true, + "key": { + "uuid": "dca693b4_28998b01", + "filename": "/PATCHSET_LEVEL", + "patchSetId": 2 + }, + "lineNbr": 0, + "author": { + "id": 1007145 + }, + "writtenOn": "2025-07-08T23:51:27Z", + "side": 1, + "message": "there is no automatic process here, nor do we document that in the file. you either add people manually, or hope someone does a drive by.", + "parentUuid": "6feafb09_2c5bc434", + "revId": "21269c3eedc428610a5cab1494b2459a7e939fc7", + "serverId": "173816e5-2b9a-37c3-8a2e-48639d4f1153" + }, + { + "unresolved": true, + "key": { + "uuid": "f498b3ca_d2e0c96c", + "filename": "/PATCHSET_LEVEL", + "patchSetId": 2 + }, + "lineNbr": 0, + "author": { + "id": 1007145 + }, + "writtenOn": "2025-07-08T23:51:27Z", + "side": 1, + "message": "i don\u0027t think we should do this. arguably the existing env options shouldn\u0027t exist either.\n\nif you want to setup global defaults on your system, this is what `~/.repoconfig/config` is intended for.\n\nso unless there\u0027s a strong reason we can\u0027t go that route, let\u0027s pull this out \u0026 start again.", + "revId": "21269c3eedc428610a5cab1494b2459a7e939fc7", + "serverId": "173816e5-2b9a-37c3-8a2e-48639d4f1153" } ] } \ No newline at end of file