From b35d71949384f5b360803244156522a40b7baa5f Mon Sep 17 00:00:00 2001 From: Gerrit User 1153491 <1153491@173816e5-2b9a-37c3-8a2e-48639d4f1153> Date: Mon, 23 Jun 2025 09:12:41 -0700 Subject: [PATCH] Create patch set 14 Change has been successfully rebased and submitted as f7a3f99dc9e92556f3a0c588633b651439b5f7db 12 is the latest approved patch-set. The change was submitted with unreviewed changes in the following files: ``` The name of the file: tests/test_subcmds_sync.py Insertions: 1, Deletions: 1. @@ -587,7 +587,7 @@ with mock.patch.object(sync, "_PostRepoFetch") as mock_post_fetch: self.cmd._UpdateRepoProject(self.opt, self.manifest, self.errors) self.manifest.repoProject.Sync_NetworkHalf.assert_not_called() - mock_post_fetch.assert_called_once() + mock_post_fetch.assert_not_called() def test_skips_local_only(self): """Test it does nothing with --local-only.""" ``` Patch-set: 14 Patch-set-description: Rebase Subject: sync: Share self-update logic between sync modes Status: merged Commit: f7a3f99dc9e92556f3a0c588633b651439b5f7db Tag: autogenerated:gerrit:merged Groups: 72c0da2b3618559d1cf96c0d9ae59dcc604a3364 Label: Verified=+1, a08fdfefcc03075f18b383054f48872cbce244e2 Gerrit User 1088583 <1088583@173816e5-2b9a-37c3-8a2e-48639d4f1153> Label: Code-Review=0, d94dadff3c7c1225f868914da8e2d5139dbd7399 Gerrit User 1088583 <1088583@173816e5-2b9a-37c3-8a2e-48639d4f1153> Label: Code-Review=+2, 44bac995cb175672c7ec84a7c8e3c6186a948ac3 Gerrit User 1142791 <1142791@173816e5-2b9a-37c3-8a2e-48639d4f1153> Label: Commit-Queue=+2, b25300167303ba788c5704627c14abcb91b2ed68 Gerrit User 1088583 <1088583@173816e5-2b9a-37c3-8a2e-48639d4f1153> Label: SUBM=+1, 92aa6af093a95fea71eb32192b1c759820b61471 Submission-id: 484041 Submitted-with: OK Submitted-with: Rule-Name: gerrit~DefaultSubmitRule Submitted-with: MAY: Verified: Gerrit User 1088583 <1088583@173816e5-2b9a-37c3-8a2e-48639d4f1153> Submitted-with: MAY: Code-Review: Gerrit User 1142791 <1142791@173816e5-2b9a-37c3-8a2e-48639d4f1153> Submitted-with: MAY: Commit-Queue: Gerrit User 1088583 <1088583@173816e5-2b9a-37c3-8a2e-48639d4f1153> Submitted-with: MAY: Bot-Commit Submitted-with: MAY: Auto-Submit Submitted-with: MAY: Lint Ours: 72c0da2b3618559d1cf96c0d9ae59dcc604a3364 Theirs: 6b8e9fc8db47a29dbb288cb2109a78e2518e616a Contains-Conflicts: false --- 72c0da2b3618559d1cf96c0d9ae59dcc604a3364 | 185 +++++++++++++++++++++++ 1 file changed, 185 insertions(+) create mode 100644 72c0da2b3618559d1cf96c0d9ae59dcc604a3364 diff --git a/72c0da2b3618559d1cf96c0d9ae59dcc604a3364 b/72c0da2b3618559d1cf96c0d9ae59dcc604a3364 new file mode 100644 index 000000000..d8cf2bedd --- /dev/null +++ b/72c0da2b3618559d1cf96c0d9ae59dcc604a3364 @@ -0,0 +1,185 @@ +{ + "comments": [], + "submitRequirementResults": [ + { + "submitRequirement": { + "name": "Code-Review", + "description": { + "value": "Submit requirement for the \u0027Code-Review\u0027 label" + }, + "applicabilityExpression": {}, + "submittabilityExpression": { + "expressionString": "label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN" + }, + "overrideExpression": {}, + "allowOverrideInChildProjects": true + }, + "applicabilityExpressionResult": {}, + "submittabilityExpressionResult": { + "value": {"expression":{"expressionString":"label:Code-Review=MAX AND -label:Code-Review=MIN"},"status":"PASS","errorMessage":{"value":null},"passingAtoms":["label:Code-Review=MAX"],"failingAtoms":["label:Code-Review=MIN"],"atomExplanations":{"value":{"label:Code-Review=MAX":"","label:Code-Review=MIN":""}}} + }, + "overrideExpressionResult": {}, + "patchSetCommitId": "72c0da2b3618559d1cf96c0d9ae59dcc604a3364", + "legacy": { + "value": false + }, + "forced": {}, + "hidden": {} + }, + { + "submitRequirement": { + "name": "Do-Not-Submit", + "description": { + "value": "Changes that have DO NOT SUBMIT in their commit message are not submittable." + }, + "applicabilityExpression": { + "value": { + "expressionString": "message:\"^.*(D|d)(O|o) (N|n)(O|o)(T|t) (S|s)(U|u)(B|b)(M|m)(I|i)(T|t).*\"" + } + }, + "submittabilityExpression": { + "expressionString": "is:false" + }, + "overrideExpression": {}, + "allowOverrideInChildProjects": false + }, + "applicabilityExpressionResult": { + "value": {"expression":{"expressionString":"message:\"^.*(D|d)(O|o) (N|n)(O|o)(T|t) (S|s)(U|u)(B|b)(M|m)(I|i)(T|t).*\""},"status":"FAIL","errorMessage":{"value":null},"passingAtoms":[],"failingAtoms":["message:\"^.*(D|d)(O|o) (N|n)(O|o)(T|t) (S|s)(U|u)(B|b)(M|m)(I|i)(T|t).*\""],"atomExplanations":{"value":{"message:\"^.*(D|d)(O|o) (N|n)(O|o)(T|t) (S|s)(U|u)(B|b)(M|m)(I|i)(T|t).*\"":""}}} + }, + "submittabilityExpressionResult": { + "value": {"expression":{"expressionString":"is:false"},"status":"NOT_EVALUATED","errorMessage":{"value":null},"passingAtoms":[],"failingAtoms":[],"atomExplanations":{"value":null}} + }, + "overrideExpressionResult": {}, + "patchSetCommitId": "72c0da2b3618559d1cf96c0d9ae59dcc604a3364", + "legacy": { + "value": false + }, + "forced": {}, + "hidden": {} + }, + { + "submitRequirement": { + "name": "No-Unresolved-Comments", + "description": { + "value": "Changes that have unresolved comments are not submittable. Unless overriden by adding the hashtag allow-unresolved-comments." + }, + "applicabilityExpression": { + "value": { + "expressionString": "has:unresolved" + } + }, + "submittabilityExpression": { + "expressionString": "-has:unresolved" + }, + "overrideExpression": { + "value": { + "expressionString": "hashtag:allow-unresolved-comments" + } + }, + "allowOverrideInChildProjects": false + }, + "applicabilityExpressionResult": { + "value": {"expression":{"expressionString":"has:unresolved"},"status":"FAIL","errorMessage":{"value":null},"passingAtoms":[],"failingAtoms":["has:unresolved"],"atomExplanations":{"value":{"has:unresolved":""}}} + }, + "submittabilityExpressionResult": { + "value": {"expression":{"expressionString":"-has:unresolved"},"status":"NOT_EVALUATED","errorMessage":{"value":null},"passingAtoms":[],"failingAtoms":[],"atomExplanations":{"value":null}} + }, + "overrideExpressionResult": { + "value": {"expression":{"expressionString":"hashtag:allow-unresolved-comments"},"status":"NOT_EVALUATED","errorMessage":{"value":null},"passingAtoms":[],"failingAtoms":[],"atomExplanations":{"value":null}} + }, + "patchSetCommitId": "72c0da2b3618559d1cf96c0d9ae59dcc604a3364", + "legacy": { + "value": false + }, + "forced": {}, + "hidden": {} + }, + { + "submitRequirement": { + "name": "Review-Enforcement", + "description": { + "value": "Two Google employees must approve the change. Uploading the change or voting positively on Code-Review count as approval. Using a trusted device is required, see go/gerrit-onboarding#review-enforcement." + }, + "applicabilityExpression": { + "value": { + "expressionString": "is:review-enforced_gerrit" + } + }, + "submittabilityExpression": { + "expressionString": "is:review-enforcement-satisfied_gerrit" + }, + "overrideExpression": {}, + "allowOverrideInChildProjects": false + }, + "applicabilityExpressionResult": { + "value": {"expression":{"expressionString":"is:review-enforced_gerrit"},"status":"PASS","errorMessage":{"value":null},"passingAtoms":["is:review-enforced_gerrit"],"failingAtoms":[],"atomExplanations":{"value":{"is:review-enforced_gerrit":""}}} + }, + "submittabilityExpressionResult": { + "value": {"expression":{"expressionString":"is:review-enforcement-satisfied_gerrit"},"status":"PASS","errorMessage":{"value":null},"passingAtoms":["is:review-enforcement-satisfied_gerrit"],"failingAtoms":[],"atomExplanations":{"value":{"is:review-enforcement-satisfied_gerrit":"Required approval count satisfied"}}} + }, + "overrideExpressionResult": {}, + "patchSetCommitId": "72c0da2b3618559d1cf96c0d9ae59dcc604a3364", + "legacy": { + "value": false + }, + "forced": {}, + "hidden": {} + }, + { + "submitRequirement": { + "name": "Verified", + "description": { + "value": "Submit requirement for the \u0027Verified\u0027 label" + }, + "applicabilityExpression": {}, + "submittabilityExpression": { + "expressionString": "label:Verified\u003dMAX AND -label:Verified\u003dMIN" + }, + "overrideExpression": {}, + "allowOverrideInChildProjects": true + }, + "applicabilityExpressionResult": {}, + "submittabilityExpressionResult": { + "value": {"expression":{"expressionString":"label:Verified=MAX AND -label:Verified=MIN"},"status":"PASS","errorMessage":{"value":null},"passingAtoms":["label:Verified=MAX"],"failingAtoms":["label:Verified=MIN"],"atomExplanations":{"value":{"label:Verified=MAX":"","label:Verified=MIN":""}}} + }, + "overrideExpressionResult": {}, + "patchSetCommitId": "72c0da2b3618559d1cf96c0d9ae59dcc604a3364", + "legacy": { + "value": false + }, + "forced": {}, + "hidden": {} + }, + { + "submitRequirement": { + "name": "Want-Code-Review-From-All", + "description": { + "value": "A \u0027Code-Review\u0027 vote is required from all human reviewers (service users that are reviewers are ignored)." + }, + "applicabilityExpression": { + "value": { + "expressionString": "footer:\"Want-Code-Review: all\" -label:Code-Review\u003e\u003d1,users\u003dhuman_reviewers" + } + }, + "submittabilityExpression": { + "expressionString": "label:Code-Review\u003e\u003d1,users\u003dhuman_reviewers" + }, + "overrideExpression": {}, + "allowOverrideInChildProjects": false + }, + "applicabilityExpressionResult": { + "value": {"expression":{"expressionString":"footer:\"Want-Code-Review: all\" -label:Code-Review>=1,users=human_reviewers"},"status":"FAIL","errorMessage":{"value":null},"passingAtoms":["label:Code-Review>=1,users=human_reviewers"],"failingAtoms":["footer:\"Want-Code-Review: all\""],"atomExplanations":{"value":{"footer:\"Want-Code-Review: all\"":"","label:Code-Review>=1,users=human_reviewers":""}}} + }, + "submittabilityExpressionResult": { + "value": {"expression":{"expressionString":"label:Code-Review>=1,users=human_reviewers"},"status":"NOT_EVALUATED","errorMessage":{"value":null},"passingAtoms":[],"failingAtoms":[],"atomExplanations":{"value":null}} + }, + "overrideExpressionResult": {}, + "patchSetCommitId": "72c0da2b3618559d1cf96c0d9ae59dcc604a3364", + "legacy": { + "value": false + }, + "forced": {}, + "hidden": {} + } + ] +} \ No newline at end of file