1
0
Fork 0

Create patch set 7

Change has been successfully rebased and submitted as 720bd1e96b

4 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:

```
The name of the file: subcmds/sync.py
Insertions: 0, Deletions: 2.

@@ -2320,8 +2320,6 @@
                 finally:
                     checkout_finish = time.time()
                     checkout_stderr = stderr_capture.getvalue()
-        elif fetch_success:
-            checkout_success = True
 
         # Consolidate all captured output.
         captured_parts = []
```


Patch-set: 7
Patch-set-description: Rebase
Subject: sync: Don't checkout if no worktree
Status: merged
Commit: 720bd1e96b
Tag: autogenerated:gerrit:merged
Groups: 8402130ca2
Label: Verified=+1, a0ed14318302cfa8fe17789d4ab8b4840f462506 Gerrit User 1088583 <1088583@173816e5-2b9a-37c3-8a2e-48639d4f1153>
Label: Code-Review=+2, bd7625cc1f945835f9df7f4a16e6c3696afd9b3d Gerrit User 1142791 <1142791@173816e5-2b9a-37c3-8a2e-48639d4f1153>
Label: Commit-Queue=+2, 21303ea5008ae6cb6a2bb088a1d7c9a2d63f543a Gerrit User 1088583 <1088583@173816e5-2b9a-37c3-8a2e-48639d4f1153>
Label: SUBM=+1, ea84c193e1e02a49cc2f18eefdcd3583f745751b
Submission-id: 492942
Submitted-with: OK
Submitted-with: Rule-Name: gerrit~DefaultSubmitRule
Submitted-with: MAY: Verified: Gerrit User 1088583 <1088583@173816e5-2b9a-37c3-8a2e-48639d4f1153>
Submitted-with: MAY: Code-Review: Gerrit User 1142791 <1142791@173816e5-2b9a-37c3-8a2e-48639d4f1153>
Submitted-with: MAY: Commit-Queue: Gerrit User 1088583 <1088583@173816e5-2b9a-37c3-8a2e-48639d4f1153>
Submitted-with: MAY: Bot-Commit
Submitted-with: MAY: Auto-Submit
Submitted-with: MAY: Lint
Ours: f7b2797035
Theirs: 25858c8b16
Contains-Conflicts: false
This commit is contained in:
Gerrit User 1153491 2025-07-23 15:57:49 -07:00 committed by Gerrit Code Review
parent 7ce00017c7
commit 8b2fbd648c

View file

@ -0,0 +1,185 @@
{
"comments": [],
"submitRequirementResults": [
{
"submitRequirement": {
"name": "Code-Review",
"description": {
"value": "Submit requirement for the \u0027Code-Review\u0027 label"
},
"applicabilityExpression": {},
"submittabilityExpression": {
"expressionString": "label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN"
},
"overrideExpression": {},
"allowOverrideInChildProjects": true
},
"applicabilityExpressionResult": {},
"submittabilityExpressionResult": {
"value": {"expression":{"expressionString":"label:Code-Review=MAX AND -label:Code-Review=MIN"},"status":"PASS","errorMessage":{"value":null},"passingAtoms":["label:Code-Review=MAX"],"failingAtoms":["label:Code-Review=MIN"],"atomExplanations":{"value":{"label:Code-Review=MAX":"","label:Code-Review=MIN":""}}}
},
"overrideExpressionResult": {},
"patchSetCommitId": "f7b2797035612902829ff8e254f6c9d84eb5a5bf",
"legacy": {
"value": false
},
"forced": {},
"hidden": {}
},
{
"submitRequirement": {
"name": "Do-Not-Submit",
"description": {
"value": "Changes that have DO NOT SUBMIT in their commit message are not submittable."
},
"applicabilityExpression": {
"value": {
"expressionString": "message:\"^.*(D|d)(O|o) (N|n)(O|o)(T|t) (S|s)(U|u)(B|b)(M|m)(I|i)(T|t).*\""
}
},
"submittabilityExpression": {
"expressionString": "is:false"
},
"overrideExpression": {},
"allowOverrideInChildProjects": false
},
"applicabilityExpressionResult": {
"value": {"expression":{"expressionString":"message:\"^.*(D|d)(O|o) (N|n)(O|o)(T|t) (S|s)(U|u)(B|b)(M|m)(I|i)(T|t).*\""},"status":"FAIL","errorMessage":{"value":null},"passingAtoms":[],"failingAtoms":["message:\"^.*(D|d)(O|o) (N|n)(O|o)(T|t) (S|s)(U|u)(B|b)(M|m)(I|i)(T|t).*\""],"atomExplanations":{"value":{"message:\"^.*(D|d)(O|o) (N|n)(O|o)(T|t) (S|s)(U|u)(B|b)(M|m)(I|i)(T|t).*\"":""}}}
},
"submittabilityExpressionResult": {
"value": {"expression":{"expressionString":"is:false"},"status":"NOT_EVALUATED","errorMessage":{"value":null},"passingAtoms":[],"failingAtoms":[],"atomExplanations":{"value":null}}
},
"overrideExpressionResult": {},
"patchSetCommitId": "f7b2797035612902829ff8e254f6c9d84eb5a5bf",
"legacy": {
"value": false
},
"forced": {},
"hidden": {}
},
{
"submitRequirement": {
"name": "No-Unresolved-Comments",
"description": {
"value": "Changes that have unresolved comments are not submittable. Unless overriden by adding the hashtag allow-unresolved-comments."
},
"applicabilityExpression": {
"value": {
"expressionString": "has:unresolved"
}
},
"submittabilityExpression": {
"expressionString": "-has:unresolved"
},
"overrideExpression": {
"value": {
"expressionString": "hashtag:allow-unresolved-comments"
}
},
"allowOverrideInChildProjects": false
},
"applicabilityExpressionResult": {
"value": {"expression":{"expressionString":"has:unresolved"},"status":"FAIL","errorMessage":{"value":null},"passingAtoms":[],"failingAtoms":["has:unresolved"],"atomExplanations":{"value":{"has:unresolved":""}}}
},
"submittabilityExpressionResult": {
"value": {"expression":{"expressionString":"-has:unresolved"},"status":"NOT_EVALUATED","errorMessage":{"value":null},"passingAtoms":[],"failingAtoms":[],"atomExplanations":{"value":null}}
},
"overrideExpressionResult": {
"value": {"expression":{"expressionString":"hashtag:allow-unresolved-comments"},"status":"NOT_EVALUATED","errorMessage":{"value":null},"passingAtoms":[],"failingAtoms":[],"atomExplanations":{"value":null}}
},
"patchSetCommitId": "f7b2797035612902829ff8e254f6c9d84eb5a5bf",
"legacy": {
"value": false
},
"forced": {},
"hidden": {}
},
{
"submitRequirement": {
"name": "Review-Enforcement",
"description": {
"value": "Two Google employees must approve the change. Uploading the change or voting positively on Code-Review count as approval. Using a trusted device is required, see go/gerrit-onboarding#review-enforcement."
},
"applicabilityExpression": {
"value": {
"expressionString": "is:review-enforced_gerrit"
}
},
"submittabilityExpression": {
"expressionString": "is:review-enforcement-satisfied_gerrit"
},
"overrideExpression": {},
"allowOverrideInChildProjects": false
},
"applicabilityExpressionResult": {
"value": {"expression":{"expressionString":"is:review-enforced_gerrit"},"status":"PASS","errorMessage":{"value":null},"passingAtoms":["is:review-enforced_gerrit"],"failingAtoms":[],"atomExplanations":{"value":{"is:review-enforced_gerrit":""}}}
},
"submittabilityExpressionResult": {
"value": {"expression":{"expressionString":"is:review-enforcement-satisfied_gerrit"},"status":"PASS","errorMessage":{"value":null},"passingAtoms":["is:review-enforcement-satisfied_gerrit"],"failingAtoms":[],"atomExplanations":{"value":{"is:review-enforcement-satisfied_gerrit":"Required approval count satisfied"}}}
},
"overrideExpressionResult": {},
"patchSetCommitId": "f7b2797035612902829ff8e254f6c9d84eb5a5bf",
"legacy": {
"value": false
},
"forced": {},
"hidden": {}
},
{
"submitRequirement": {
"name": "Verified",
"description": {
"value": "Submit requirement for the \u0027Verified\u0027 label"
},
"applicabilityExpression": {},
"submittabilityExpression": {
"expressionString": "label:Verified\u003dMAX AND -label:Verified\u003dMIN"
},
"overrideExpression": {},
"allowOverrideInChildProjects": true
},
"applicabilityExpressionResult": {},
"submittabilityExpressionResult": {
"value": {"expression":{"expressionString":"label:Verified=MAX AND -label:Verified=MIN"},"status":"PASS","errorMessage":{"value":null},"passingAtoms":["label:Verified=MAX"],"failingAtoms":["label:Verified=MIN"],"atomExplanations":{"value":{"label:Verified=MAX":"","label:Verified=MIN":""}}}
},
"overrideExpressionResult": {},
"patchSetCommitId": "f7b2797035612902829ff8e254f6c9d84eb5a5bf",
"legacy": {
"value": false
},
"forced": {},
"hidden": {}
},
{
"submitRequirement": {
"name": "Want-Code-Review-From-All",
"description": {
"value": "A \u0027Code-Review\u0027 vote is required from all human reviewers (service users that are reviewers are ignored)."
},
"applicabilityExpression": {
"value": {
"expressionString": "footer:\"Want-Code-Review: all\" -label:Code-Review\u003e\u003d1,users\u003dhuman_reviewers"
}
},
"submittabilityExpression": {
"expressionString": "label:Code-Review\u003e\u003d1,users\u003dhuman_reviewers"
},
"overrideExpression": {},
"allowOverrideInChildProjects": false
},
"applicabilityExpressionResult": {
"value": {"expression":{"expressionString":"footer:\"Want-Code-Review: all\" -label:Code-Review>=1,users=human_reviewers"},"status":"FAIL","errorMessage":{"value":null},"passingAtoms":["label:Code-Review>=1,users=human_reviewers"],"failingAtoms":["footer:\"Want-Code-Review: all\""],"atomExplanations":{"value":{"footer:\"Want-Code-Review: all\"":"","label:Code-Review>=1,users=human_reviewers":""}}}
},
"submittabilityExpressionResult": {
"value": {"expression":{"expressionString":"label:Code-Review>=1,users=human_reviewers"},"status":"NOT_EVALUATED","errorMessage":{"value":null},"passingAtoms":[],"failingAtoms":[],"atomExplanations":{"value":null}}
},
"overrideExpressionResult": {},
"patchSetCommitId": "f7b2797035612902829ff8e254f6c9d84eb5a5bf",
"legacy": {
"value": false
},
"forced": {},
"hidden": {}
}
]
}