From 873a0ef73d4a628130a5fc41803e499c94475cba Mon Sep 17 00:00:00 2001 From: Gerrit User 1088583 <1088583@173816e5-2b9a-37c3-8a2e-48639d4f1153> Date: Tue, 17 Jun 2025 13:30:34 -0700 Subject: [PATCH] Update patch set 1 Patch Set 1: (1 comment) Patch-set: 1 Attention: {"person_ident":"Gerrit User 1088583 \u003c1088583@173816e5-2b9a-37c3-8a2e-48639d4f1153\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_1088583\u003e replied on the change"} Attention: {"person_ident":"Gerrit User 4157134 \u003c4157134@173816e5-2b9a-37c3-8a2e-48639d4f1153\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_1088583\u003e replied on the change"} --- c59dcd63217c846138120a0e482c5f8a63515377 | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) diff --git a/c59dcd63217c846138120a0e482c5f8a63515377 b/c59dcd63217c846138120a0e482c5f8a63515377 index 84b23b427..48c25e7c0 100644 --- a/c59dcd63217c846138120a0e482c5f8a63515377 +++ b/c59dcd63217c846138120a0e482c5f8a63515377 @@ -88,6 +88,24 @@ "parentUuid": "e3e2f41c_f47ce859", "revId": "c59dcd63217c846138120a0e482c5f8a63515377", "serverId": "173816e5-2b9a-37c3-8a2e-48639d4f1153" + }, + { + "unresolved": true, + "key": { + "uuid": "36948f99_3107123d", + "filename": "/PATCHSET_LEVEL", + "patchSetId": 1 + }, + "lineNbr": 0, + "author": { + "id": 1088583 + }, + "writtenOn": "2025-06-17T20:30:34Z", + "side": 1, + "message": "I think that would make it harder to debug since we\u0027d be masking that error. IMO this is working correctly in that it fails loudly when the superproject doesn\u0027t exist, and it\u0027s up to the caller to determine when it should call `repo_id` at all", + "parentUuid": "d33354e6_3e0d4589", + "revId": "c59dcd63217c846138120a0e482c5f8a63515377", + "serverId": "173816e5-2b9a-37c3-8a2e-48639d4f1153" } ] } \ No newline at end of file