Tools/git-repo
1
0
Fork 0
Code Activity

git_superproject: fix AttributeError in Superproject logging

Browse source 
Ensure _git_event_log is initialized before use in _LogMessage. This
avoids crashes when _git_event_log is accessed before it's set, such as
during repo info.

Bug: 435317391
Change-Id: I3adc32d6a9377558e852bbb43f9cf82041fcf1bc
Reviewed-on: https://gerrit-review.googlesource.com/c/git-repo/+/498521
Commit-Queue: Gavin Mak <gavinmak@google.com>
Tested-by: Gavin Mak <gavinmak@google.com>
Reviewed-by: Scott Lee <ddoman@google.com>
This commit is contained in:
Gavin Mak 2025-08-14 19:30:06 +00:00 • committed by LUCI
parent d534a5537f
commit 854fe440f2
1 changed files with 2 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

3
git_superproject.py
View file

@ -190,7 +190,8 @@ class Superproject:
message = f"{self._LogMessagePrefix()} {fmt.format(*inputs)}" message = f"{self._LogMessagePrefix()} {fmt.format(*inputs)}"
if self._print_messages: if self._print_messages:
print(message, file=sys.stderr) print(message, file=sys.stderr)
self._git_event_log.ErrorEvent(message, fmt) if self._git_event_log:
self._git_event_log.ErrorEvent(message, fmt)
def _LogMessagePrefix(self): def _LogMessagePrefix(self):
"""Returns the prefix string to be logged in each log message""" """Returns the prefix string to be logged in each log message"""