Tools/git-repo
1
0
Fork 0
Code Activity

Update patch set 11

Browse source 
Patch Set 11: Code-Review+1

(1 comment)

Patch-set: 11
Reviewer: Gerrit User 4127492 <4127492@173816e5-2b9a-37c3-8a2e-48639d4f1153>
Label: Code-Review=+1, 060b0ff9a5f88d0f27ace78ce8d29a01e1be1b5e
Attention: {"person_ident":"Gerrit User 4127492 \u003c4127492@173816e5-2b9a-37c3-8a2e-48639d4f1153\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_4127492\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 1002666 \u003c1002666@173816e5-2b9a-37c3-8a2e-48639d4f1153\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_4127492\u003e replied on the change"}
This commit is contained in:
Gerrit User 4127492 2025-06-05 00:52:25 -07:00 • committed by Gerrit Code Review
parent 38b4b56345
commit 81a5a3dfa6
1 changed files with 18 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

18
54227f79bcb8a6af52c6075066ac681c7b9e02f4
View file

@ -52,6 +52,24 @@
"parentUuid": "eb8f03d1_0b40ea3c",
"revId": "54227f79bcb8a6af52c6075066ac681c7b9e02f4",
"serverId": "173816e5-2b9a-37c3-8a2e-48639d4f1153"
},
{
"unresolved": false,
"key": {
"uuid": "ac5f2971_628712d1",
"filename": "subcmds/sync.py",
"patchSetId": 4
},
"lineNbr": 1753,
"author": {
"id": 4127492
},
"writtenOn": "2025-06-05T07:52:25Z",
"side": 1,
"message": "Thanks! In patchset 10, I added `RepoHook.AddOptionGroup(p, \u0027post-sync\u0027)` to `_Options()` in `sync.py`, consistent with how `upload.py` does it for `pre-upload`.\n\nThis allows `opt` to include the expected flags (`bypass_hooks`, `allow_all_hooks`, `ignore_hooks`) without needing to manually inject them.\n\nPreviously, I had assumed `opt` didn’t exist or was missing those attributes — I’ve corrected that understanding and aligned this patch with the standard hook integration pattern.\n\nLet me know if there’s anything else to adjust!",
"parentUuid": "39848544_2c387cf8",
"revId": "54227f79bcb8a6af52c6075066ac681c7b9e02f4",
"serverId": "173816e5-2b9a-37c3-8a2e-48639d4f1153"
}
]
}