1
0
Fork 0

Update patch set 4

Patch Set 4:

(1 comment)

Patch-set: 4
Attention: {"person_ident":"Gerrit User 4127492 \u003c4127492@173816e5-2b9a-37c3-8a2e-48639d4f1153\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_1002666\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 1002666 \u003c1002666@173816e5-2b9a-37c3-8a2e-48639d4f1153\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_1002666\u003e replied on the change"}
This commit is contained in:
Gerrit User 1002666 2025-06-03 12:39:45 -07:00 committed by Gerrit Code Review
parent d142535fec
commit 7a5c459704

View file

@ -0,0 +1,21 @@
{
"comments": [
{
"unresolved": true,
"key": {
"uuid": "39f7fbc6_e71028de",
"filename": "subcmds/sync.py",
"patchSetId": 4
},
"lineNbr": 1753,
"author": {
"id": 1002666
},
"writtenOn": "2025-06-03T19:39:45Z",
"side": 1,
"message": "I think you should be using the `RepoHook.FromSubcmd()` static method to populate most of the constructor args. Check the usage in `subcmds/upload.py`.",
"revId": "54227f79bcb8a6af52c6075066ac681c7b9e02f4",
"serverId": "173816e5-2b9a-37c3-8a2e-48639d4f1153"
}
]
}