Tools/git-repo
1
0
Fork 0
Code Activity

Make usage of open safer by setting binary mode and closing fds

Browse source 
Signed-off-by: Shawn O. Pearce <sop@google.com>
This commit is contained in:
Shawn O. Pearce 2009-04-18 14:48:03 -07:00
parent accc56d82b
commit 76ca9f8145
4 changed files with 23 additions and 11 deletions
Download patch file Download diff file Expand all files Collapse all files

4
git_refs.py
View file

@ -101,7 +101,7 @@ class GitRefs(object):
def _ReadPackedRefs(self):
path = os.path.join(self._gitdir, 'packed-refs')
try:
fd = open(path, 'r')
fd = open(path, 'rb')
mtime = os.path.getmtime(path)
except IOError:
return
@ -138,7 +138,7 @@ class GitRefs(object):
def _ReadLoose1(self, path, name):
try:
fd = open(path, 'r')
fd = open(path, 'rb')
mtime = os.path.getmtime(path)
except OSError:
return