From 210e5c63ab04a37552bccb732b7b2150f3e3998e Mon Sep 17 00:00:00 2001 From: Gerrit User 1153491 <1153491@173816e5-2b9a-37c3-8a2e-48639d4f1153> Date: Mon, 23 Jun 2025 16:06:34 -0700 Subject: [PATCH] Create patch set 12 Change has been successfully rebased and submitted as 99b5a17f2c951fe5979100c36e7e1dbb4c61b36c Patch-set: 12 Patch-set-description: Rebase Subject: sync: Share final error handling logic between sync modes Status: merged Commit: 99b5a17f2c951fe5979100c36e7e1dbb4c61b36c Tag: autogenerated:gerrit:merged Groups: 5de91e86d0e99dcd12844d2f402dd380cae31ff7 Label: Verified=+1, 12c95680f622f09659a9a9e7b04867c36d6e1f4f Gerrit User 1088583 <1088583@173816e5-2b9a-37c3-8a2e-48639d4f1153> Label: Code-Review=+2, 7cee0625694ec7f32095c1fd35279bc1a09f3edd Gerrit User 1142791 <1142791@173816e5-2b9a-37c3-8a2e-48639d4f1153> Label: Commit-Queue=+2, 4dc5276e86eb3845f6a92fb8c15f96f522f72770 Gerrit User 1088583 <1088583@173816e5-2b9a-37c3-8a2e-48639d4f1153> Label: SUBM=+1, 64a19f3161bc741346949312b7f52a7a6b866682 Submission-id: 484541 Submitted-with: OK Submitted-with: Rule-Name: gerrit~DefaultSubmitRule Submitted-with: MAY: Verified: Gerrit User 1088583 <1088583@173816e5-2b9a-37c3-8a2e-48639d4f1153> Submitted-with: MAY: Code-Review: Gerrit User 1142791 <1142791@173816e5-2b9a-37c3-8a2e-48639d4f1153> Submitted-with: MAY: Commit-Queue: Gerrit User 1088583 <1088583@173816e5-2b9a-37c3-8a2e-48639d4f1153> Submitted-with: MAY: Bot-Commit Submitted-with: MAY: Auto-Submit Submitted-with: MAY: Lint Ours: b7db606c7bf3e0524dac5f21509026fcfba1da56 Theirs: df3c4017f9a81e268b23728c273e1c8cd8957434 Contains-Conflicts: false --- b7db606c7bf3e0524dac5f21509026fcfba1da56 | 182 +++++++++++++++++++++++ 1 file changed, 182 insertions(+) diff --git a/b7db606c7bf3e0524dac5f21509026fcfba1da56 b/b7db606c7bf3e0524dac5f21509026fcfba1da56 index e9580f071..3aaa2dc93 100644 --- a/b7db606c7bf3e0524dac5f21509026fcfba1da56 +++ b/b7db606c7bf3e0524dac5f21509026fcfba1da56 @@ -17,5 +17,187 @@ "revId": "b7db606c7bf3e0524dac5f21509026fcfba1da56", "serverId": "173816e5-2b9a-37c3-8a2e-48639d4f1153" } + ], + "submitRequirementResults": [ + { + "submitRequirement": { + "name": "Code-Review", + "description": { + "value": "Submit requirement for the \u0027Code-Review\u0027 label" + }, + "applicabilityExpression": {}, + "submittabilityExpression": { + "expressionString": "label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN" + }, + "overrideExpression": {}, + "allowOverrideInChildProjects": true + }, + "applicabilityExpressionResult": {}, + "submittabilityExpressionResult": { + "value": {"expression":{"expressionString":"label:Code-Review=MAX AND -label:Code-Review=MIN"},"status":"PASS","errorMessage":{"value":null},"passingAtoms":["label:Code-Review=MAX"],"failingAtoms":["label:Code-Review=MIN"],"atomExplanations":{"value":{"label:Code-Review=MAX":"","label:Code-Review=MIN":""}}} + }, + "overrideExpressionResult": {}, + "patchSetCommitId": "b7db606c7bf3e0524dac5f21509026fcfba1da56", + "legacy": { + "value": false + }, + "forced": {}, + "hidden": {} + }, + { + "submitRequirement": { + "name": "Do-Not-Submit", + "description": { + "value": "Changes that have DO NOT SUBMIT in their commit message are not submittable." + }, + "applicabilityExpression": { + "value": { + "expressionString": "message:\"^.*(D|d)(O|o) (N|n)(O|o)(T|t) (S|s)(U|u)(B|b)(M|m)(I|i)(T|t).*\"" + } + }, + "submittabilityExpression": { + "expressionString": "is:false" + }, + "overrideExpression": {}, + "allowOverrideInChildProjects": false + }, + "applicabilityExpressionResult": { + "value": {"expression":{"expressionString":"message:\"^.*(D|d)(O|o) (N|n)(O|o)(T|t) (S|s)(U|u)(B|b)(M|m)(I|i)(T|t).*\""},"status":"FAIL","errorMessage":{"value":null},"passingAtoms":[],"failingAtoms":["message:\"^.*(D|d)(O|o) (N|n)(O|o)(T|t) (S|s)(U|u)(B|b)(M|m)(I|i)(T|t).*\""],"atomExplanations":{"value":{"message:\"^.*(D|d)(O|o) (N|n)(O|o)(T|t) (S|s)(U|u)(B|b)(M|m)(I|i)(T|t).*\"":""}}} + }, + "submittabilityExpressionResult": { + "value": {"expression":{"expressionString":"is:false"},"status":"NOT_EVALUATED","errorMessage":{"value":null},"passingAtoms":[],"failingAtoms":[],"atomExplanations":{"value":null}} + }, + "overrideExpressionResult": {}, + "patchSetCommitId": "b7db606c7bf3e0524dac5f21509026fcfba1da56", + "legacy": { + "value": false + }, + "forced": {}, + "hidden": {} + }, + { + "submitRequirement": { + "name": "No-Unresolved-Comments", + "description": { + "value": "Changes that have unresolved comments are not submittable. Unless overriden by adding the hashtag allow-unresolved-comments." + }, + "applicabilityExpression": { + "value": { + "expressionString": "has:unresolved" + } + }, + "submittabilityExpression": { + "expressionString": "-has:unresolved" + }, + "overrideExpression": { + "value": { + "expressionString": "hashtag:allow-unresolved-comments" + } + }, + "allowOverrideInChildProjects": false + }, + "applicabilityExpressionResult": { + "value": {"expression":{"expressionString":"has:unresolved"},"status":"FAIL","errorMessage":{"value":null},"passingAtoms":[],"failingAtoms":["has:unresolved"],"atomExplanations":{"value":{"has:unresolved":""}}} + }, + "submittabilityExpressionResult": { + "value": {"expression":{"expressionString":"-has:unresolved"},"status":"NOT_EVALUATED","errorMessage":{"value":null},"passingAtoms":[],"failingAtoms":[],"atomExplanations":{"value":null}} + }, + "overrideExpressionResult": { + "value": {"expression":{"expressionString":"hashtag:allow-unresolved-comments"},"status":"NOT_EVALUATED","errorMessage":{"value":null},"passingAtoms":[],"failingAtoms":[],"atomExplanations":{"value":null}} + }, + "patchSetCommitId": "b7db606c7bf3e0524dac5f21509026fcfba1da56", + "legacy": { + "value": false + }, + "forced": {}, + "hidden": {} + }, + { + "submitRequirement": { + "name": "Review-Enforcement", + "description": { + "value": "Two Google employees must approve the change. Uploading the change or voting positively on Code-Review count as approval. Using a trusted device is required, see go/gerrit-onboarding#review-enforcement." + }, + "applicabilityExpression": { + "value": { + "expressionString": "is:review-enforced_gerrit" + } + }, + "submittabilityExpression": { + "expressionString": "is:review-enforcement-satisfied_gerrit" + }, + "overrideExpression": {}, + "allowOverrideInChildProjects": false + }, + "applicabilityExpressionResult": { + "value": {"expression":{"expressionString":"is:review-enforced_gerrit"},"status":"PASS","errorMessage":{"value":null},"passingAtoms":["is:review-enforced_gerrit"],"failingAtoms":[],"atomExplanations":{"value":{"is:review-enforced_gerrit":""}}} + }, + "submittabilityExpressionResult": { + "value": {"expression":{"expressionString":"is:review-enforcement-satisfied_gerrit"},"status":"PASS","errorMessage":{"value":null},"passingAtoms":["is:review-enforcement-satisfied_gerrit"],"failingAtoms":[],"atomExplanations":{"value":{"is:review-enforcement-satisfied_gerrit":"Required approval count satisfied"}}} + }, + "overrideExpressionResult": {}, + "patchSetCommitId": "b7db606c7bf3e0524dac5f21509026fcfba1da56", + "legacy": { + "value": false + }, + "forced": {}, + "hidden": {} + }, + { + "submitRequirement": { + "name": "Verified", + "description": { + "value": "Submit requirement for the \u0027Verified\u0027 label" + }, + "applicabilityExpression": {}, + "submittabilityExpression": { + "expressionString": "label:Verified\u003dMAX AND -label:Verified\u003dMIN" + }, + "overrideExpression": {}, + "allowOverrideInChildProjects": true + }, + "applicabilityExpressionResult": {}, + "submittabilityExpressionResult": { + "value": {"expression":{"expressionString":"label:Verified=MAX AND -label:Verified=MIN"},"status":"PASS","errorMessage":{"value":null},"passingAtoms":["label:Verified=MAX"],"failingAtoms":["label:Verified=MIN"],"atomExplanations":{"value":{"label:Verified=MAX":"","label:Verified=MIN":""}}} + }, + "overrideExpressionResult": {}, + "patchSetCommitId": "b7db606c7bf3e0524dac5f21509026fcfba1da56", + "legacy": { + "value": false + }, + "forced": {}, + "hidden": {} + }, + { + "submitRequirement": { + "name": "Want-Code-Review-From-All", + "description": { + "value": "A \u0027Code-Review\u0027 vote is required from all human reviewers (service users that are reviewers are ignored)." + }, + "applicabilityExpression": { + "value": { + "expressionString": "footer:\"Want-Code-Review: all\" -label:Code-Review\u003e\u003d1,users\u003dhuman_reviewers" + } + }, + "submittabilityExpression": { + "expressionString": "label:Code-Review\u003e\u003d1,users\u003dhuman_reviewers" + }, + "overrideExpression": {}, + "allowOverrideInChildProjects": false + }, + "applicabilityExpressionResult": { + "value": {"expression":{"expressionString":"footer:\"Want-Code-Review: all\" -label:Code-Review>=1,users=human_reviewers"},"status":"FAIL","errorMessage":{"value":null},"passingAtoms":["label:Code-Review>=1,users=human_reviewers"],"failingAtoms":["footer:\"Want-Code-Review: all\""],"atomExplanations":{"value":{"footer:\"Want-Code-Review: all\"":"","label:Code-Review>=1,users=human_reviewers":""}}} + }, + "submittabilityExpressionResult": { + "value": {"expression":{"expressionString":"label:Code-Review>=1,users=human_reviewers"},"status":"NOT_EVALUATED","errorMessage":{"value":null},"passingAtoms":[],"failingAtoms":[],"atomExplanations":{"value":null}} + }, + "overrideExpressionResult": {}, + "patchSetCommitId": "b7db606c7bf3e0524dac5f21509026fcfba1da56", + "legacy": { + "value": false + }, + "forced": {}, + "hidden": {} + } ] } \ No newline at end of file