Tools/git-repo
1
0
Fork 0
Code Activity

subcmds: delete redundant dest= settings

Browse source 
Add a test to enforce this too.

Change-Id: I80b5cf567aa33db9c24b53428c66d69f9c1d8d74
Reviewed-on: https://gerrit-review.googlesource.com/c/git-repo/+/478481
Commit-Queue: Mike Frysinger <vapier@google.com>
Tested-by: Mike Frysinger <vapier@google.com>
Reviewed-by: Scott Lee <ddoman@google.com>
This commit is contained in:
Mike Frysinger 2025-05-22 14:14:45 -04:00 • committed by LUCI
parent 8d37f61471
commit 06338abe79
18 changed files with 45 additions and 52 deletions
Download patch file Download diff file Expand all files Collapse all files

7
subcmds/forall.py
View file

@ -133,7 +133,7 @@ without iterating through the remaining projects.
@staticmethod
def _cmd_option(option, _opt_str, _value, parser):
setattr(parser.values, option.dest, list(parser.rargs))
setattr(parser.values, option.dest or "command", list(parser.rargs))
while parser.rargs:
del parser.rargs[0]
@ -141,7 +141,6 @@ without iterating through the remaining projects.
p.add_option(
"-r",
"--regex",
dest="regex",
action="store_true",
help="execute the command only on projects matching regex or "
"wildcard expression",
@ -149,7 +148,6 @@ without iterating through the remaining projects.
p.add_option(
"-i",
"--inverse-regex",
dest="inverse_regex",
action="store_true",
help="execute the command only on projects not matching regex or "
"wildcard expression",
@ -157,7 +155,6 @@ without iterating through the remaining projects.
p.add_option(
"-g",
"--groups",
dest="groups",
help="execute the command only on projects matching the specified "
"groups",
)
@ -165,14 +162,12 @@ without iterating through the remaining projects.
"-c",
"--command",
help="command (and arguments) to execute",
dest="command",
action="callback",
callback=self._cmd_option,
)
p.add_option(
"-e",
"--abort-on-errors",
dest="abort_on_errors",
action="store_true",
help="abort if a command exits unsuccessfully",
)