Tools/git-repo
1
0
Fork 0
Code Activity

manifest: add basic path checks for <copyfile> & <linkfile>

Browse source 
Reject paths in <copyfile> & <linkfile> that point outside of their
respective scopes.  This validates paths while parsing the manifest
as this should be quick & cheap: we don't access the filesystem as
this code runs before we've synced.

Bug: https://crbug.com/gerrit/11218
Change-Id: I8e17bb91f3f5b905a9d76391b29fbab4cb77aa58
Reviewed-on: https://gerrit-review.googlesource.com/c/git-repo/+/232932
Tested-by: Mike Frysinger <vapier@google.com>
Reviewed-by: Mike Frysinger <vapier@google.com>
Reviewed-by: Michael Mortensen <mmortensen@google.com>
This commit is contained in:
Mike Frysinger 2019-07-31 23:32:58 -04:00
parent f5525fb310
commit 04122b7261
4 changed files with 170 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

2
docs/manifest-format.md
View file

@ -338,7 +338,7 @@ It's just like copyfile and runs at the same time as copyfile but
instead of copying it creates a symlink.
The symlink is created at "dest" (relative to the top of the tree) and
points to the path specified by "src".
points to the path specified by "src" which is a path in the project.
Parent directories of "dest" will be automatically created if missing.